[OE-core] [PATCH] libmad: avoid using legacy _thumb overrides

[Andre McCurdy]

On Tue, Mar 22, 2016 at 7:44 AM, Ming Liu <liu.ming50 at gmail.com> wrote:
> From: Ming Liu <peter.x.liu at external.atlascopco.com>
>
> _thumb had been dropped from overrides since commit 351443d7:
> [ feature-arm-thumb.inc: drop legacy _thumb and _thumb-interwork over-rides ]
>
> Use bb.utils.contains('TUNE_FEATURES', 'thumb', **, **, d) instead.

Finding thumb in TUNE_FEATURES is not a valid way to determine whether
or not a particular package is being compiled as Thumb.

Since this recipe explicitly sets ARM_INSTRUCTION_SET = "arm", I think
the correct fix is simply to remove the "EXTRA_OECONF_append_thumb"
line.

> [YOCTO #9323]
>
> Signed-off-by: Ming Liu <peter.x.liu at external.atlascopco.com>
> ---
>  meta/recipes-multimedia/libmad/libmad_0.15.1b.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb b/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> index 9e08b16..15a9d96 100644
> --- a/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> +++ b/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> @@ -27,7 +27,7 @@ inherit autotools pkgconfig
>
>  EXTRA_OECONF = "-enable-speed --enable-shared"
>  # The ASO's don't take any account of thumb...
> -EXTRA_OECONF_append_thumb = " --disable-aso --enable-fpm=default"
> +EXTRA_OECONF_append = "${@bb.utils.contains('TUNE_FEATURES', 'thumb', ' --disable-aso --enable-fpm=default', '', d)}"
>  EXTRA_OECONF_append_arm = " --enable-fpm=arm"
>
>  do_configure_prepend () {
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core