[OE-core] [PATCH v1] libmad: avoid using legacy _thumb overrides
Martin Jansa
martin.jansa at gmail.com
Wed Mar 23 14:41:07 UTC 2016
On Wed, Mar 23, 2016 at 03:19:58PM +0100, Ming Liu wrote:
> From: Peter Liu <peter.x.liu at external.atlascopco.com>
>
> _thumb had been dropped from overrides since commit 351443d7:
> [ feature-arm-thumb.inc: drop legacy _thumb and _thumb-interwork over-rides ]
>
> Change to set EXTRA_OECONF_append by checking ARM_INSTRUCTION_SET instead.
This also isn't right, ARM_INSTRUCTION_SET can be set to "thumb" even
when MACHINE doesn't support it by having "thumb" in TUNE_FEATURES.
You'll need to replicate the conditionals which were used in the tune
files or just revert that cleanup if you find "thumb" override still
useful.
> [YOCTO #9323]
>
> Signed-off-by: Peter Liu <peter.x.liu at external.atlascopco.com>
> ---
> meta/recipes-multimedia/libmad/libmad_0.15.1b.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb b/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> index 9e08b16..4c15db2 100644
> --- a/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> +++ b/meta/recipes-multimedia/libmad/libmad_0.15.1b.bb
> @@ -27,7 +27,7 @@ inherit autotools pkgconfig
>
> EXTRA_OECONF = "-enable-speed --enable-shared"
> # The ASO's don't take any account of thumb...
> -EXTRA_OECONF_append_thumb = " --disable-aso --enable-fpm=default"
> +EXTRA_OECONF_append = " ${@['', '--disable-aso --enable-fpm=default'][d.getVar('ARM_INSTRUCTION_SET', True) == 'thumb']}"
> EXTRA_OECONF_append_arm = " --enable-fpm=arm"
>
> do_configure_prepend () {
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160323/a95ce5e4/attachment-0002.sig>
More information about the Openembedded-core
mailing list