[OE-core] [PATCH] gcc-configure-common.inc: duplicate armv7a over-ride for armv8a

[Khem Raj]

On Wed, Mar 23, 2016 at 10:16 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
> On Wed, Mar 23, 2016 at 9:19 PM, Khem Raj <raj.khem at gmail.com> wrote:
>>
>> On Mar 23, 2016 8:19 PM, "Andre McCurdy" <armccurdy at gmail.com> wrote:
>>>
>>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>>> ---
>>>  meta/recipes-devtools/gcc/gcc-configure-common.inc | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc
>>> b/meta/recipes-devtools/gcc/gcc-configure-common.inc
>>> index f4f76bd..a7b8d63 100644
>>> --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
>>> +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
>>> @@ -65,6 +65,7 @@ EXTRA_OECONF_append_mips64eln32 = " --with-abi=64
>>> --with-arch-64=mips64 --with-t
>>>  EXTRA_OECONF_append_armv6 = " --with-arch=armv6"
>>>  EXTRA_OECONF_append_armv7a = " --with-arch=armv7-a"
>>>  EXTRA_OECONF_append_armv7ve = " --with-arch=armv7-a"
>>> +EXTRA_OECONF_append_armv8a = " --with-arch=armv7-a"
>>
>> Armv8 is different architecture and even gcc backends for armv8 arent shared
>> with armv7. This change doesn't look right to me. What are you fixing with
>> this change
>
> In the context of oe-core machine specific over-rides, "armv8a"
> signifies that we're building 32bit code for an ARMv8-A class CPU.
> See:
>
>   http://git.openembedded.org/openembedded-core/commit/?h=master-next&id=823af99d825375485d64fcb82c00fb85004813b8
>
> (Maybe it would have been better to use aarch32 as the over-ride in this case?).

ah I did not know this patch has made it in. I had concerns about it.
Its quite confusing to call armv8a as 32bit since thats wrong
representation. It should be renamed to aarch32 atleast.
since thats the execution state of armv8a architecture thats what this
file is doing. armv8a support aarch64/aarch32/(thumb2 in aarch2 state)

Please submit a rename patch with adjustments before starting to use
it widely in metadata