[OE-core] [PATCH 3/3] image-live.bbclass/image-vm.bbclass: remove duplicated code

Richard Purdie richard.purdie at linuxfoundation.org
Tue Mar 29 11:59:15 UTC 2016


On Tue, 2016-03-29 at 00:59 -0700, Robert Yang wrote:
> Move the common code to image.bbclass and remove duplicated ones.

Whilst I do like the idea of this patch set, I don't like generic
functions called "populate", or adding EFI variables to image.bbclass
itself.

I believe that some refactoring does make a lot of sense here but this
doesn't look right. The diffstats don't seem to suggest a large volume
of common code either (as yet).

Cheers,

Richard




More information about the Openembedded-core mailing list