[OE-core] [master][PATCH] gcc-cross{, -canadian}: remove --with-linker-hash-style

[Khem Raj]

> On May 2, 2016, at 1:09 PM, Christopher Larson <kergoth at gmail.com> wrote:
> 
> From: Christopher Larson <chris_larson at mentor.com>
> 
> We explicitly set the hash style to gnu in our LDFLAGS. Setting the default to
> this in the toolchain, while convenient, actually hides bugs, as a failure to
> obey LDFLAGS isn't noticed. By removing this, it's not dissimilar to how we
> poison the sysroot -- rather than relying on the default, notice right away if
> somoeone isn't obeying the needed flags.
> 
> This will result in a failure to obey LDFLAGS causing a GNU_HASH QA failure,
> which is what's often seen with external toolchains. This brings us all on the
> same page, and makes sure a failure to obey LDFLAGS is seen early.
> 


Default or gnu linkers is to use sysv for legacy reasons and by passing this option
to configuring the toolchain we want to make sure that components are using sane defaults
even if they have not configured these options.

if you do not pass the right linker flags from compiler driver and also ignore
the LDFLAGS then you now have a safe pass for the app to build without GNU hash
while I understand it will spread the external toolchain’s pains into internal toolchain
I fail to understand the benefit of doing this otherwise.

> Signed-off-by: Christopher Larson <chris_larson at mentor.com>
> ---
> meta/recipes-devtools/gcc/gcc-4.9.inc | 1 -
> meta/recipes-devtools/gcc/gcc-5.3.inc | 1 -
> 2 files changed, 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/gcc/gcc-4.9.inc b/meta/recipes-devtools/gcc/gcc-4.9.inc
> index 7e03f31..c187918 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.9.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.9.inc
> @@ -111,7 +111,6 @@ EXTRA_OECONF_BASE = "\
>     --disable-bootstrap \
>     --disable-libmudflap \
>     --with-system-zlib \
> -    --with-linker-hash-style=${LINKER_HASH_STYLE} \
>     --enable-linker-build-id \
>     --with-ppl=no \
>     --with-cloog=no \
> diff --git a/meta/recipes-devtools/gcc/gcc-5.3.inc b/meta/recipes-devtools/gcc/gcc-5.3.inc
> index 9808be1..f2eda18 100644
> --- a/meta/recipes-devtools/gcc/gcc-5.3.inc
> +++ b/meta/recipes-devtools/gcc/gcc-5.3.inc
> @@ -112,7 +112,6 @@ EXTRA_OECONF_BASE = "\
>     --disable-bootstrap \
>     --disable-libmudflap \
>     --with-system-zlib \
> -    --with-linker-hash-style=${LINKER_HASH_STYLE} \
>     --enable-linker-build-id \
>     --with-ppl=no \
>     --with-cloog=no \
> --
> 2.8.0
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160502/d406edc3/attachment-0002.sig>