[OE-core] [PATCH v3 4/6] bmap-tools: generate standalone script

[Christopher Larson]

On Wed, May 4, 2016 at 7:01 AM, Ed Bartosh <ed.bartosh at linux.intel.com>
wrote:

> On Tue, May 03, 2016 at 07:33:58PM +0000, Christopher Larson wrote:
> > On Tue, May 3, 2016 at 7:31 PM, Christopher Larson <clarson at kergoth.com>
> > wrote:
> >
> > >
> > >
> > > On Mon, May 2, 2016 at 12:22 PM, Ed Bartosh <
> ed.bartosh at linux.intel.com>
> > > wrote:
> > >
> > >> Generated standalone bmaptool script that is more convenient
> > >> to use than native script. It can be run straight from
> > >> its location ./tmp/deploy/tools/bmaptool. The script doesn't
> > >> depend on anything except Python.
> > >>
> > >> Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
> > >>
> > >
> > > You're right that this is very handy, but we hit a problem when
> building
> > > from shared state. This uses do_deploy to deploy bmaptool into
> > > DEPLOY_DIR_IMAGE, but IMAGE_DEPENDS only depends on
> do_populate_sysroot,
> > > not do_deploy, so an image build from sstate won't write this script
> out.
> > >
> > > I don't know the right way to fix this, but it's a problem. I just ran
> > > into it :)
> > >
> >
> > Also, the convention is to add do_deploy before do_build, not before
> > do_package, otherwise do_deploy's checksum is included int he checksums
> of
> > do_package and subsequent tasks, even though its output isn't used by any
> > subsequent tasks.
>
> I also found this a bit unusual to put the tool into deploy/tools.
> That's why I isolated this change. I think it requires some more
> testing, but the rest of patchset can be accepted without it.


Yeah, putting it there does require some discussion in general. Personally,
I'm in favor of such a thing, because we don't want to put generated
convenience tools in the sysroot, since we tell people explicitly to not
use sysroot contents directly.

Regarding getting it built for the image, I'd suggest adding something like
IMAGE_TASKDEPENDS to image_type.bbclass, which is basically like
IMAGE_DEPENDS, but with the task included. I.e. IMAGE_TASKDEPENDS_bmap =
"bmap-tools-native:do_deploy". Then you wouldn't need the 'before
do_package', and it'd fix the from-sstate usage.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160504/909080fe/attachment-0002.html>