[OE-core] [for-master][RFC PATCH 0/3] Support template files for wic wks

Christopher Larson clarson at kergoth.com
Thu May 12 18:07:36 UTC 2016


On Thu, May 12, 2016 at 11:06 AM, Christopher Larson <clarson at kergoth.com>
wrote:

>
> On Sun, May 8, 2016 at 9:05 AM, Jeremy ROSEN <jeremy.rosen at smile.fr>
> wrote:
>
>> Le 02/05/2016 21:23, Christopher Larson a écrit :
>>
>>> From: Christopher Larson <chris_larson at mentor.com>
>>>
>>> This adds support for .wks.in files as WKS_FILE.
>>>
>>> These files are treated as the contents of a bitbake variable, so usual
>>> bitbake variable references are supported. I considered using another
>>> templating mechanism, for example the one used by yocto-layer, but then
>>> we'd
>>> end up largely mapping metadata variables to template fields anyway,
>>> which is
>>> a pointless indirection. Let bitbake expand the variables directly
>>> instead.
>>>
>>> This feature lets us, for example, reference ${APPEND} in --append, and
>>> avoid
>>> hardcoding the serial console tty in the wks file, and let the user's
>>> changes
>>> to APPEND affect wic the way they do the other image construction
>>> mechanisms.
>>>
>>> The template is read in and set in a variable at parse time, so changes
>>> to the
>>> variables referenced by the template will result in rebuilding the image.
>>>
>>> It's been suggested that the name should better reflect how its contents
>>> are
>>> used, i.e. .bbin or so. I've also considered including something like
>>> 'bbv' or
>>> similar, to indicate its contents are that of a bitbake value. I think
>>> this
>>> should be discussed.
>>>
>>> I'd love to hear questions or comments on this. I think the value is
>>> clear,
>>> and it's something we need to solve, but I'd like to hear if others
>>> agree or
>>> disagree on that, and whether this implementation is appropriate.
>>
>>
Given that there don't seem to be any real objections here, I'm going to
re-submit this as a non-RFC patch series to try to get it merged. If anyone
has any issues adding this feature, let me know. Thanks for the feedback.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160512/7253f861/attachment-0002.html>


More information about the Openembedded-core mailing list