[OE-core] [PATCH v2 08/10] wic: selftest: do not repeat core-image-minimal

[Burton, Ross]

On 10 November 2016 at 12:18, Maciej Borzecki <maciej.borzecki at rndity.com>
wrote:

>      def test_qemux86_directdisk(self):
>          """Test creation of qemux-86-directdisk image"""
>          image = "qemux86-directdisk"
> -        self.assertEqual(0, runCmd("wic create %s -e core-image-minimal" \
> -                                   % image).status)
> +        wic_cmd_vars = {
> +            'wks': image,
> +            'image': self.OE_IMAGE,
> +        }
> +        self.assertEqual(0, runCmd("wic create %(wks)s -e %(image)s" \
> +                                   % wic_cmd_vars).status)
>

Is it just me who thinks that this is more understandable then?

def test_qemux86_directdisk(self):
  self.assertEqual(0, runCmd("wic create qemux86-directdisk -e
core-image-minimal").status)
  self.assertEqual(1, len(glob(os.path.join(self.resultdir,
"core-image-minimal-*direct"))))

Not my test case so just an opinion :)

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161110/33b33a9f/attachment-0002.html>