[OE-core] [PATCH] sanity: add function to check for git config user

Paul Eggleton paul.eggleton at linux.intel.com
Sun Oct 2 22:46:35 UTC 2016


Hi Stephano,

On Sun, 02 Oct 2016 15:17:31 Stephano Cetola wrote:
> If attempting to patch a git repo without a proper git config setup,
> an error will occur saying user.name/user.email are needed by git
> am/apply. After 0f698dfd1c8bbc0d53ae7977e26685a7a3df52a3, it was
> simple enough to reproduce this error by creating a kernel patch and
> using a container to build.
> 
> This patch abstracts out functionality that existed in buildhistory
> for use in other classes. It also adds a call to this functionality
> to the kernel-yocto class.

For the logic implemented by patch.bbclass, we already fixed this by forcing a 
dummy value for the commit name and email (since it's not actually the user 
doing the commit, it's the build system). If we're adding this to cover 
similar automated scenarios where the user isn't the one making the commit, 
then I think we should be fixing those to do the same instead.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the Openembedded-core mailing list