[OE-core] [PATCH 0/7] linux-yocto: consolidated (and hopefully final) pull request

[Bruce Ashfield]

On Mon, Oct 3, 2016 at 11:57 AM, Bruce Ashfield <bruce.ashfield at gmail.com>
wrote:

>
>
> On Mon, Oct 3, 2016 at 11:51 AM, Bruce Ashfield <
> bruce.ashfield at windriver.com> wrote:
>
>> On 2016-10-03 11:45 AM, Burton, Ross wrote:
>>
>>>
>>> On 3 October 2016 at 06:54, Bruce Ashfield <bruce.ashfield at windriver.com
>>> <mailto:bruce.ashfield at windriver.com>> wrote:
>>>
>>>     The big thing to note about this update .. is that the libc-headers
>>> bump
>>>     to the 4.8 final tarball picked up some uapi headers that broke the
>>>     build
>>>     of ppp. I never would have thought it was possible, but it happened.
>>>
>>>
>>> | In file included from
>>> /data/poky-master/tmp-glibc/sysroots/intel-corei7-64/usr/inc
>>> lude/linux/if_tunnel.h:6:0,
>>> |                  from iptunnel.c:39:
>>> |
>>> /data/poky-master/tmp-glibc/sysroots/intel-corei7-64/usr/inc
>>> lude/linux/ip.h:85:8:
>>> error: redefinition of 'struct iphdr'
>>> |  struct iphdr {
>>> |         ^~~~~
>>> | In file included from iptunnel.c:29:0:
>>> |
>>> /data/poky-master/tmp-glibc/sysroots/intel-corei7-64/usr/inc
>>> lude/netinet/ip.h:44:8:
>>> note: originally defined here
>>> |  struct iphdr
>>> |         ^~~~~
>>> | <builtin>: recipe for target 'iptunnel.o' failed
>>> | make: *** [iptunnel.o] Error 1
>>> | ERROR: Function failed: do_compile (log file is located at
>>> /data/poky-master/tmp-glibc/work/corei7-64-poky-linux/net-to
>>> ols/1.60-26-r0/temp/log.do_compile.27643)
>>>
>>> Looks like net-tools is broken by something else too.
>>>
>>
>> I'm out of the office in about one hour. So someone else is
>> going to have to pick up the libc-headers fix.
>>
>
>
> Switching to my gmail, so I can follow along.
>
> I do have about a half hour now, I'll check the net uapi code in the
> kernel and see
> if there's another fixup I can do.
>
> These errors have been lurking for about the last year, the answer from
> the kernel
> folks is typically "change the order of your includes".
>
> So there are two routes to fix it. See if there's a newer userspace with
> the includes
> changed, or do what I did, take the change out of libc-headers.
>

Yep. Same criminals, it is very likely this. I started a build, if it
breaks, I'll test a removal
of this:

-----------

commit 1fe8e0f074c77aa41aaa579345a9e675acbebfa9

Author: Mikko Rapeli <mikko.rapeli at iki.fi>

Date:   Mon Aug 22 20:32:39 2016 +0200


    include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and
linux/in6.h



    Fixes userspace compilation errors like:



    error: field <E2><80><98>iph<E2><80><99> has incomplete type

    error: field <E2><80><98>prefix<E2><80><99> has incomplete type



    Signed-off-by: Mikko Rapeli <mikko.rapeli at iki.fi>

    Signed-off-by: David S. Miller <davem at davemloft.net>


:100644 100644 1046f5515174... 777b6cdb1b7b... M
include/uapi/linux/if_tunnel.h

--------


>
> I'll check to see if I can do the latter here.
>
> Out of curiosity, what image type is this ?  built core-image-sato,
> kernel-dev for
> x86-64 and they all worked.
>
> Bruce
>
>
>>
>> Cheers,
>>
>> Bruce
>>
>>
>>> Ross
>>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end"
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161003/d398a1b1/attachment-0002.html>