[OE-core] [PATCH] classes/sstate.bbclass: Enable thread lock when checkstatus

Aníbal Limón anibal.limon at linux.intel.com
Tue Oct 4 16:46:58 UTC 2016


This patch depends on bitbake one,

http://lists.openembedded.org/pipermail/bitbake-devel/2016-October/008129.html

Cheers,
	alimon

On 10/04/2016 11:45 AM, Aníbal Limón wrote:
> The checkstatus function fires an event to notify bitbake UI about
> the progress of the task, this function is implemented using ThreadPool
> and is causing event lose when multiple threads tries to fire an event
> (writes over socket/fd).
> 
> [YOCTO #10330]
> 
> Signed-off-by: Aníbal Limón <anibal.limon at linux.intel.com>
> ---
>  meta/classes/sstate.bbclass | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index 6f0c791..172384b 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -851,15 +851,19 @@ def sstate_checkhashes(sq_fn, sq_task, sq_hash, sq_hashfn, d, siginfo=False):
>  
>          if tasklist:
>              bb.event.fire(bb.event.ProcessStarted("Checking sstate mirror object availability", len(tasklist)), d)
> +
>              import multiprocessing
>              nproc = min(multiprocessing.cpu_count(), len(tasklist))
>  
> +            bb.event.enable_threadlock()
>              pool = oe.utils.ThreadedPool(nproc, len(tasklist),
>                      worker_init=checkstatus_init, worker_end=checkstatus_end)
>              for t in tasklist:
>                  pool.add_task(checkstatus, t)
>              pool.start()
>              pool.wait_completion()
> +            bb.event.disable_threadlock()
> +
>              bb.event.fire(bb.event.ProcessFinished("Checking sstate mirror object availability"), d)
>              if whitelist and missing:
>                  bb.fatal('Required artifacts were unavailable - exiting')
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161004/279ea524/attachment-0002.sig>


More information about the Openembedded-core mailing list