[OE-core] [PATCH V2] subprocess: remove strings and migrate to direct arrays

Richard Purdie richard.purdie at linuxfoundation.org
Sun Oct 9 11:44:28 UTC 2016


On Thu, 2016-10-06 at 20:09 -0700, Stephano Cetola wrote:
> 
> When using subprocess call and check_output, it is better to use
> arrays
> rather than strings when possible to avoid whitespace and quoting
> problems.
> 
> [ YOCTO #9342 ]
> 
> Signed-off-by: Stephano Cetola <stephano.cetola at linux.intel.com>
> ---
>  meta/lib/oe/distro_check.py    |   2 +-
>  meta/lib/oe/package.py         |  13 +--
>  meta/lib/oe/package_manager.py | 218 ++++++++++++++++++++-----------
> ----------
>  3 files changed, 114 insertions(+), 119 deletions(-)
This triggered a lot of errors on the autobuilder:

http://autobuilder.yocto.io:8010/builders/build-appliance/builds/70
http://autobuilder.yocto.io:8010/builders/nightly-x86/builds/75
http://autobuilder.yocto.io:8010/builders/nightly-x86-64/builds/73
http://autobuilder.yocto.io:8010/builders/nightly-x86-64-lsb/builds/72
http://autobuilder.yocto.io:8010/builders/nightly-x86-lsb/builds/73
http://autobuilder.yocto.io:8010/builders/nightly-wic/builds/73
http://autobuilder.yocto.io:8010/builders/nightly-qa-extras/builds/55
http://autobuilder.yocto.io:8010/builders/nightly-oe-selftest/builds/70
http://autobuilder.yocto.io:8010/builders/nightly-multilib/builds/78

and similar errors on the main AB. I've confirmed it is this patch
which causes the issue. Presumably some errors are occurring but are
currently silently being ignored?

Its probably worth looking into what is going on in case there is some
real issue here but at this point given the complexity of the changes
I'm leaning towwards deferring this for 2.3.

Cheers,

Richard



More information about the Openembedded-core mailing list