[OE-core] [PATCH] glibc: Fix timestamp of plural.c after unpack

[Mark Hatle]

On 10/11/16 11:46 AM, Gary Thomas wrote:
> On 2016-10-11 11:22, Enrico Scholz wrote:
>> Mark Hatle <mark.hatle-CWA4WttNNZF54TAoqtyWWQ at public.gmane.org> writes:
>>
>>> My understanding of the issue is that the extraction of the plural.c and
>>> plural.y files happens so quickly that it is unclear to make if one is older
>>> then the other -- so it sometimes uses bison to rebuild the plural.c.
>>
>> When this is really the case, this can apply to the workaround too.  So,
>> there should be added a 'sleep 1' before the 'touch' or (better?) remove
>> plural.c to enforce a rebuild.
> 
> I believe that's the opposite of the desired action, i.e. to always use
> the packaged plural.c and never rely on the plural.y=>plural.c transformation.
> 
>>
>>>> +do_unpack_workaround() {
>>>> +	touch ${S}/intl/plural.c
>>>> +}
> 

Correct.  We want to use the included version from glibc, -unless- there is a
patch that has modified the plural.y.

So doing this as an intermediate operation between unpack and patch should
correct the timestamp issue, while still allowing a patch to modify plural.y to
trigger an automatic regeneration (and any advantages or problems introduced by
the regeneration operation.)

As for the sleep 1, we've generally seen that is a long enough delay in tasks
that that is not necessary.  Most filesystems seem to have sub second accuracy.
However, if it does become an issue, I agree the sleep 1 is likely the only
solution to ensure the stamp has changed sufficiently..

--Mark