[OE-core] [PATCH 2/2] insane: display names instead of ELF machine numbers

[Gary Thomas]

On 2016-10-11 14:19, Ross Burton wrote:
> The 'arch' QA test currently simply outputs the ELF machine field as a number
> which isn't helpful.  Display this as a human-readable name to make it clearer
> to the user what the problem is.
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  meta/classes/insane.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index b347638..17c9284 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -543,8 +543,8 @@ def package_qa_check_arch(path,name,d, elf, messages):
>      # Check the architecture and endiannes of the binary
>      if not ((machine == elf.machine()) or \
>          ((("virtual/kernel" in provides) or bb.data.inherits_class("module", d) ) and (target_os == "linux-gnux32" or target_os == "linux-gnun32"))):
> -        package_qa_add_message(messages, "arch", "Architecture did not match (%d to %d) on %s" % \
> -                 (machine, elf.machine(), package_qa_clean_path(path,d)))
> +        package_qa_add_message(messages, "arch", "Architecture did not match (%s, expected %s) on %s" % \
> +                 (oe.qa.elf_machine_to_string(elf.machine()), oe.qa.elf_machine_to_string(machine), package_qa_clean_path(path,d)))
>      elif not ((bits == elf.abiSize()) or  \
>          ((("virtual/kernel" in provides) or bb.data.inherits_class("module", d) ) and (target_os == "linux-gnux32" or target_os == "linux-gnun32"))):
>          package_qa_add_message(messages, "arch", "Bit size did not match (%d to %d) %s on %s" % \
>

Did you mean to swap the items?  The old version used
   machine, elf.machine()
and this version uses
   elf.machine(), machine

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------