[OE-core] [PATCH 1/2] pixbufcache: Ensure sysroot dependencies are satisfied

[Kyle Russell]

The symptoms sound very similar as far as the postinst exception; however,
I don't think I've seen an error specifically for libpcre before.  I think
in one instance, gdk-pixbuf-query-loaders itself was missing, and in
another instance, one of the libraries provided by harfbuzz. Looking
through the logs, the do_populate_sysroot_setscene tasks for these packages
never ran. (My memory might be off slightly about the specific packages
that were missing, though in each failure instance they were listed in the
librsvg PIXBUFCACHE_SYSROOT_DEPS variable.)

Since PIXBUFCACHE_SYSROOT_DEPS didn't appear to be used anywhere, and we
kept hitting what appeared to be dependency issues with setscene tasks not
running, we thought maybe this hunk was inadvertantly removed from
pixbufcache.bbclass. We've been running with this patch for a few weeks on
our jethro branch and haven't seen any subsequent postinst failures (except
the two packages I addressed in my second patch). The logs from the failed
builds have already been reaped from the build slave, or I could go back to
verify exactly which error messages we encountered in postinst.

Should these setscene dependencies be satisfied another way?

On Tue, Oct 11, 2016 at 2:29 PM, Martin Jansa <martin.jansa at gmail.com>
wrote:

> On Tue, Oct 11, 2016 at 10:17:16AM -0400, Kyle Russell wrote:
> > Reverts part of b411085fefc8582d24c172db5f6610705eb44c2f
> >
> > Makes sure gdk-pixbuf-native populates the sysroot during setscene;
> > otherwise, gdk-pixbuf-query-loaders may not actually be available at the
> > time the completion function runs, causing a build failure.
> >
> > Similarly, packages providing loader libraries should append to
> > PIXBUFCACHE_SYSROOT_DEPS with their runtime dependencies.
>
> Is this related to
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=10102
> ? Or are you seeing completely different errors?
>
> > Signed-off-by: Kyle Russell <bkylerussell at gmail.com>
> > ---
> >  meta/classes/pixbufcache.bbclass | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/meta/classes/pixbufcache.bbclass
> b/meta/classes/pixbufcache.bbclass
> > index dbe11e1..3c1e398 100644
> > --- a/meta/classes/pixbufcache.bbclass
> > +++ b/meta/classes/pixbufcache.bbclass
> > @@ -65,3 +65,17 @@ pixbufcache_sstate_postinst() {
> >       fi
> >  }
> >
> > +# Add all of the dependencies of gdk-pixbuf as dependencies of
> > +# do_populate_sysroot_setscene so that pixbufcache_sstate_postinst can
> work
> > +# (otherwise gdk-pixbuf-query-loaders may not exist or link). Only add
> > +# gdk-pixbuf-native if we're not building gdk-pixbuf itself.
> > +#
> > +# Packages that use this class should extend this variable with their
> runtime
> > +# dependencies.
> > +PIXBUFCACHE_SYSROOT_DEPS = ""
> > +PIXBUFCACHE_SYSROOT_DEPS_class-native = "\
> > +    ${@['gdk-pixbuf-native:do_populate_sysroot_setscene', '']['${BPN}'
> == 'gdk-pixbuf']} \
> > +"
> > +
> > +do_populate_sysroot_setscene[depends] += "${PIXBUFCACHE_SYSROOT_DEPS}"
> > +do_populate_sysroot[depends] += "${@d.getVar('PIXBUFCACHE_SYSROOT_DEPS',
> True).replace('_setscene','')}"
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161011/044a579d/attachment-0002.html>