[OE-core] Two kmeta's not allowed for master?

[Ulf Magnusson]

On Tue, Oct 18, 2016 at 2:56 PM, Vesa Jääskeläinen
<vesa.jaaskelainen at vaisala.com> wrote:
> On 2016-10-11 16:38, Nathan Rossi wrote:
>>
>> On Tue, Oct 11, 2016 at 11:15 PM,  <vesa.jaaskelainen at vaisala.com> wrote:
>>>
>>> Hi,
>>>
>>> I was trying out how well 'master' branch compiles in our environment.
>>>
>>> We are using meta-xilinx and then we have custom BSP layer which
>>> bbappends linux-xlnx.
>>>
>>> When using meta-xilinx as standalone (w/o our BSP layer) I can get it
>>> tocompile.
>>>
>>> However when using it with combo meta-xilinx and our BSP we get failure
>>> on do_kernel_metadata due to missing scc files.
>>>
>>> It seems that there can no longer be two kmeta entries in SRC_URI.
>>>
>>> meta-xilinx's linux-xlnx.inc has:
>>> file://xilinx-base;type=kmeta;destsuffix=xilinx-base
>>
>> linux-xlnx has multiple kmeta sources. The one you mention here:
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/meta-xilinx/tree/recipes-kernel/linux/linux-xlnx.inc#n13
>>
>> And two more (added by a separate include):
>>
>> http://git.yoctoproject.org/cgit/cgit.cgi/meta-xilinx/tree/recipes-kernel/linux/linux-xilinx-configs.inc#n8
>>
>> So I don't think this is an issue due to the number of type=kmeta sources.
>>
>> Regards,
>> Nathan
>>
>>> our bbappend has:
>>> file://meta;type=kmeta;destsuffix=meta
>>>
>>> In krogoth this works fine.
>>>
>>> Is this expected change?
>
>
> I had to remove 'meta' from paths in KERNEL_FEATURES:
>
> -KERNEL_FEATURES_append += "meta/cfg/net/netfilter.scc"
> +KERNEL_FEATURES_append += "cfg/net/netfilter.scc"

Unrelated nit: += is never needed with _append (though an initial
space would need to be added). See the note in
http://www.yoctoproject.org/docs/2.2/bitbake-user-manual/bitbake-user-manual.html#override-style-operation-advantages.

>
> After this it seems to compile nicely with master.
>
> Thanks,
> Vesa Jääskeläinen

Cheers,
Ulf