[OE-core] [OE-Core][meta-oe][PATCH] glmark2: Enabling c++ 11 features

[Khem Raj]

> On Oct 17, 2016, at 11:49 PM, Amarnath Valluri <amarnath.valluri at intel.com> wrote:
> 
> 
> 
> On Friday 14 October 2016 05:13 PM, Khem Raj wrote:
>> On Fri, Oct 14, 2016 at 3:21 PM, Amarnath Valluri
>> <amarnath.valluri at intel.com> <mailto:amarnath.valluri at intel.com> wrote:
>>> > The failure was:
>>> > | ../src/image-reader.cpp: In member function 'bool PNGReader::init(const
>>> > string&)':
>>> > | ../src/image-reader.cpp:123:16: error: 'unique_ptr' in namespace 'std' does
>>> > not name a template type
>>> >
>>> > This change enables c++11 features, as code useing them.
>>> >
>>> > Signed-off-by: Amarnath Valluri <amarnath.valluri at intel.com> <mailto:amarnath.valluri at intel.com>
>>> > ---
>>> >  meta-oe/recipes-benchmark/glmark2/glmark2_git.bb | 3 +++
>>> >  1 file changed, 3 insertions(+)
>>> >
>>> > diff --git a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>>> > index 396ae70..4cb233b 100644
>>> > --- a/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>>> > +++ b/meta-oe/recipes-benchmark/glmark2/glmark2_git.bb
>>> > @@ -28,6 +28,9 @@ PACKAGECONFIG ?= "${@bb.utils.contains('DISTRO_FEATURES', 'x11 opengl', 'x11-gl
>>> >                    ${@bb.utils.contains('DISTRO_FEATURES', 'wayland opengl', 'wayland-gl wayland-gles2', '', d)} \
>>> >                    drm-gl drm-gles2"
>>> >
>>> > +# Enable C++11 features
>>> > +CXXFLAGS += "--std=c++11"
>> gcc6 now defaults to  -std=gnu++14,so I have couple of  questions here
>> 
>>  Are you pinning it to c++11 because it doesnt compile with c++14 ? or
>> is it because package is explicitly overrding the std option. In latter case
>> perhaps its better to patch the package and also submit it upstream
>> 
> This failure was visible with gcc version 5.4(GCCVERSION=5.%).  With gcc6 It built successfully.
> 

I see, you should mention such things in commit message.

> - Amarnath
> 
> 
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki
> Business Identity Code: 0357606 - 4
> Domiciled in Helsinki
> 
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161019/6426dbd6/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161019/6426dbd6/attachment-0002.sig>