[OE-core] [master][morty][PATCH] libunwind: add ptest support

[Jagadeesh Krishnanjanappa]

Hi Tudor,


> Hi Jagadeesh,
>
> > The patch include below changes:
> ...
> > 2. Some of the libunwind test cases such as run-check-namespace,
> >    run-coredump-unwind require debug symbols to be present in
> >    libunwind library. So set INHIBIT_PACKAGE_STRIP to "1".
> > --- a/meta/recipes-support/libunwind/libunwind_git.bb
> > +++ b/meta/recipes-support/libunwind/libunwind_git.bb
> ...
> > +INHIBIT_PACKAGE_STRIP = "1"
> > +
>
> Thanks for reviewing the patch.


> The change above have the effect of inhibiting the package strip even if
> ptest  is not enabled at all. I think this have to be something specific to
> ptest.
> You may consider using INSANE_SKIP_${PN}-ptest [1] and add unstripped
> binaries needed for ptest in {PN}-ptest (along with the original - stripped
> - ones)
>

I didn't get how unstripped and stripped binaries can co-exist in a single
package called ${PN}-test.
The split_and_strip_files function keeps files containing debug symbols in
a separate directory
( like ../.debug/..). Do you mean to say include files containing debug
symbols (i,e debugdirectory) in ${PN}-test package and
set  INSANE_SKIP_${PN}-ptest += "debug-files"
to prevent packaging .debug directories in non -dbg package.

This doesn't help,  as run-coredump-unwind requires unstripped "crasher"
 program to be present at target, to get procedure names using libuwind
APIs.


or simply consider the appropriate tests as XFAIL for openembedded.
>
Yes, for such test (e.g: run-coredump-unwind) XFAIL is fine, if
INHIBIT_PACKAGE_STRIP = "1" is
not used.

Regards,
Jagadeesh

>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20161026/2e9f03c9/attachment-0002.html>