[OE-core] [PATCH] wic: Add dosfstools-native mtools-native to dependencies

[Khem Raj]

On Wed, Oct 26, 2016 at 2:27 AM, Ed Bartosh <ed.bartosh at linux.intel.com> wrote:
> Hi Khem,
>
> On Tue, Oct 25, 2016 at 06:50:17PM -0700, Khem Raj wrote:
>> these tools are needed for building wic images for some
>> boards e.g. overo/gumstix
> NAK
>
> Usage of native tools depends on .wks content: modules, partition types,
> etc. Your change will cause unnecessary build activity for some
> machines/wks files where those tools are not used.
>
> I'd suggest to put these dependencies to board-dependent meta.
> Please, look how it's done for genericx86, beaglebone and edgerouter:
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/include/genericx86-common.inc
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/beaglebone.conf
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/edgerouter.conf
>
yes, agreed, I was trying to see if it could be made easy for using
wic out of box but then there
are many machine specific deps would make it futile I guess.

>> Signed-off-by: Khem Raj <raj.khem at gmail.com>
>> ---
>>  meta/classes/image_types.bbclass | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
>> index a7fffbc..be7e38c 100644
>> --- a/meta/classes/image_types.bbclass
>> +++ b/meta/classes/image_types.bbclass
>> @@ -298,7 +298,7 @@ IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native"
>>  IMAGE_DEPENDS_ubi = "mtd-utils-native"
>>  IMAGE_DEPENDS_ubifs = "mtd-utils-native"
>>  IMAGE_DEPENDS_multiubi = "mtd-utils-native"
>> -IMAGE_DEPENDS_wic = "parted-native"
>> +IMAGE_DEPENDS_wic = "parted-native dosfstools-native mtools-native"
>>
>>  # This variable is available to request which values are suitable for IMAGE_FSTYPES
>>  IMAGE_TYPES = " \
>> --
>> 2.10.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Regards,
> Ed