[OE-core] [PATCHv2 24/26] lttng-tools: do not install manpages in ptest package

[Nathan Lynch]

On 10/28/2016 10:12 AM, Alexander Kanavin wrote:
> Signed-off-by: Alexander Kanavin <alexander.kanavin at linux.intel.com>
> ---
>  meta/recipes-kernel/lttng/lttng-tools_git.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_git.bb b/meta/recipes-kernel/lttng/lttng-tools_git.bb
> index 016346f..18259e4 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_git.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_git.bb
> @@ -113,4 +113,7 @@ do_install_ptest () {
>  	# checkpatch.pl is unneeded on target and causes file-rdeps QA
>  	# warnings.
>  	rm -f ${D}${PTEST_PATH}/extras/checkpatch.pl
> +
> +        # Remove manpages if they are built
> +        rm -f ${D}${PTEST_PATH}/doc/man/*.[0-9]
>  }


This actually breaks running the lttng-tools test suite on the target:

root at qemux86-64:/usr/lib/lttng-tools/ptest# cat run-ptest
#!/bin/sh
# Without --ignore-exit, the tap harness causes any FAILs within a
# test plan to raise ERRORs; this is just noise.
makeargs="LOG_DRIVER_FLAGS=--ignore-exit"
make -t all >/dev/null 2>&1 && exec make -s $makeargs check 2>/dev/null

root at qemux86-64:/usr/lib/lttng-tools/ptest# sh -x run-ptest
+ makeargs=LOG_DRIVER_FLAGS=--ignore-exit
+ make -t all

root at qemux86-64:/usr/lib/lttng-tools/ptest# echo $?
2

root at qemux86-64:/usr/lib/lttng-tools/ptest# make -s -t all
make[2]: *** No rule to make target 'lttng-health-check.3', needed by
'all-am'.  Stop.
make[1]: *** [Makefile:537: all-recursive] Error 1
make: *** [Makefile:570: all-recursive] Error 1


I'd rather see "do not install shared libraries in ptest package" go in
first as it fixes an existing problem without regressing lttng-tools-ptest.

I'm looking at reworking do_install_ptest to do a selective copy, as you
suggested earlier, so maybe just drop this patch?