[OE-core] should a "*git.bb" recipe lock that recipe to a fixed version?

[Robert P. J. Day]

On Sun, 30 Oct 2016, Khem Raj wrote:

>       On Oct 30, 2016, at 4:36 PM, Burton, Ross <ross.burton at intel.com> wrote:
>
> On 30 October 2016 at 17:35, Robert P. J. Day <rpjday at crashcourse.ca> wrote:
>         fair enough ... i'm embarrassed to admit i didn't really understand
>       the versioning selection so i'm going to examine it way more carefully
>       now. i wonder how many recipes in oe-core are "_git" recipes that, in
>       the end, just lock down to a specific version. as you say, i was a bit
>       surprised.
>
> Personally I've been endorsing the practise where _git.bb is only
> used for recipes that are actually tracking git development
> branches, and if it's just a release that it simply fetched over git
> via a SHA of a release tag then the recipe should be _1.2.3.bb for
> clarity.
>
> with a system integrators hat on I agree. With developer hat on I do not.

khem:

  could you expand on that? now that i understand how the versioning
works, i'll be more careful in the future, but it's still misleading
for a "_git"-named recipe file to be locked to a particular version.

  AFAICT, there are plenty of OE recipes that download via git, but
are still named as being version locked. eg, here's
meta/recipes-devtools/file/file_5.28.bb:

  SRC_URI = "git://github.com/file/file.git \
        file://debian-742262.patch \
        file://0001-Add-P-prompt-into-Usage-info.patch \
        "

  SRCREV = "3c521817322a6bf5160cfeb09b9145ccde587b2a"

i'm assuming that that particular SRCREV corresponds to release
version 5,28, so that makes perfect sense.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================