[OE-core] [PATCH 3/3] pulseaudio: fix to manage user services corretly

[ChenQi]

On 09/07/2016 06:29 PM, Pau Espin Pedrol wrote:
>
>
> Pau Espin Pedrol
>
> 2016-09-07 11:22 GMT+02:00 Chen Qi <Qi.Chen at windriver.com 
> <mailto:Qi.Chen at windriver.com>>:
>
>     Make use of the new SYSTEMD_USER_SERVICE variable added in
>     systemd.bbclass
>     to manage user services in pulseaudio-server package.
>
>     Signed-off-by: Chen Qi <Qi.Chen at windriver.com
>     <mailto:Qi.Chen at windriver.com>>
>     ---
>      meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 4 ++--
>      1 file changed, 2 insertions(+), 2 deletions(-)
>
>     diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
>     b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
>     index 6ed79ef..f3754d7 100644
>     --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
>     +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
>     @@ -124,8 +124,8 @@ FILES_${PN}-conf = "${sysconfdir}"
>      FILES_${PN}-bin +=
>     "${sysconfdir}/default/volatiles/volatiles.04_pulse"
>      FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-*
>     ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules
>     */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*"
>
>     -#SYSTEMD_PACKAGES = "${PN}-server"
>     -SYSTEMD_SERVICE_${PN}-server = "pulseaudio.service"
>     +SYSTEMD_PACKAGES = "${PN}-server"
>     +SYSTEMD_USER_SERVICE_${PN}-server = "pulseaudio.service
>     pulseaudio.socket"
>
> I think specifying "pulseaudio.socket" for 
> SYSTEMD_USER_SERVICE_${PN}-server should be enough, systemd.bbclass is 
> going to add the .service file afair.

Add both:
chenqi at pek-hostel-deb01:~/poky/build-systemd [1] $ ls 
tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/rootfs/etc/systemd/user
default.target.wants  sockets.target.wants

Add pulseaudio.socket:
chenqi at pek-hostel-deb01:~/poky/build-systemd [1] $ ls 
tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/rootfs/etc/systemd/user
sockets.target.wants

They have different results.
I don't know a lot about pulseaudio. Can you confirm that 
pulseaudio.socket is enough?

Regards,
Chen Qi

>      FILES_${PN}-misc = "${bindir}/* ${libdir}/pulseaudio/libpulsedsp.so"
>
>     --
>     1.9.1
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core at lists.openembedded.org
>     <mailto:Openembedded-core at lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20160908/883989f7/attachment-0002.html>