[OE-core] [PATCH] autotools/siteinfo: Tweak CONFIG_SITE handling for determism/races

Otavio Salvador otavio.salvador at ossystems.com.br
Wed Sep 21 12:41:35 UTC 2016


On Wed, Sep 21, 2016 at 7:53 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> As things stand there are multiple races in the CONFIG_SITE handling
> where checksums can change depending on whether site directories
> exist or not when parsing happens. This is bad.
>
> Secondly, there is a build race that occurs if you build virtuals
> in parallel with the "main" recipe, since the main recipe is parsed
> when the virtual is (since it sets variables like BBCLASSEXTEND)
> and with the current code, it may look for files and directories
> which could be created/destroyed which the loop is executing. This
> is also bad.
>
> The aclocal-copy directory should only ever be accessed by the call
> from autotools.bbclass. This chanages the parameter name to make it

... This changes the parameter ...

> clear and ensures all callers have the right usage, neatly avoiding
> all the problems above. Also added better comments.
>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750



More information about the Openembedded-core mailing list