[OE-core] [PATCH 0/1] pseudo: add prefix for log and make log consistent

[Seebs]

On 28 Sep 2016, at 21:31, Robert Yang wrote:

> Thanks for the reply, I tested your patch from git repo, it doesn't 
> work,
> the message goes to the terminal:
> Child process exit status 4: lock_held

This, it turns out, is a result of a much worse bug which somehow 
previously evaded detection,
and just happened to work by blind luck or coincidence or something.

Which is that pseudo_logfile() was returning, not a file descriptor, but 
"either 0 or -1", but I was then treating it as a file descriptor.

So actually the messages were going to fd 0, not to fd 2, in this case.

Fixed with a one-line patch:
-	return 0;
+	return fd;

(And actually, I think it may make sense to go change those messages 
from pseudo_diag to pseudo_debug, since they're basically useless unless 
you're debugging the startup code.)

-s