[OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source

[Choong, Yin Thong]

Hi,
Once I change to github.com below error pop out. Seem like it miss align with the patch compare with github.com logrotate source. Both package seem got miss align on the version. When I compare yoctoproject logrotate.c and github logrotate.c it has big different (as attached), there even got different parameter count on some API function. Let’s stick with yoctoproject.org/mirror 1st ? Or I check back the github to get for suitable version? Then I may need to rename bbrecipe filename base on the github version? Suggestion?

https://downloads.yoctoproject.org/mirror/sources/logrotate-3.9.1.tar.gz
https://github.com/logrotate/logrotate/archive/r3-9-1.tar.gz

ERROR: logrotate-3.9.1-r0 do_patch: Command Error: 'quilt --quiltrc /home/yinthong/rebeccapoky/build/tmp/work/i586-poky-linux/logrotate/3.9.1-r0/recipe-sysroot-native/etc/quiltrc push' exited with 0  Output:
Applying patch act-as-mv-when-rotate.patch
can't find file to patch at input line 20
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From 68f29ab490cf987aa34b5f4caf1784b58a021308 Mon Sep 17 00:00:00 2001
|From: Robert Yang <liezhi.yang at windriver.com>
|Date: Tue, 17 Feb 2015 21:08:07 -0800
|Subject: [PATCH] Act as the "mv" command when rotate log
|
|Act as the "mv" command when rotate log, first rename, if failed, then
|read and write.
|
|Upstream-Status: Pending
|
|Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
|---
| logrotate.c |   71 +++++++++++++++++++++++++++++++++++++++++++++++++----------
| 1 file changed, 59 insertions(+), 12 deletions(-)
|
|diff --git a/logrotate.c b/logrotate.c
|index d3deb6a..cf8bf2c 100644
|--- a/logrotate.c
|+++ b/logrotate.c
--------------------------
No file to patch.  Skipping patch.
6 out of 6 hunks ignored
Patch act-as-mv-when-rotate.patch does not apply (enforce with -f)
ERROR: logrotate-3.9.1-r0 do_patch: Function failed: patch_do_patch
ERROR: Logfile of failure stored in: /home/yinthong/rebeccapoky/build/tmp/work/i586-poky-linux/logrotate/3.9.1-r0/temp/log.do_patch.130676
ERROR: Task (/home/yinthong/rebeccapoky/meta/recipes-extended/logrotate/logrotate_3.9.1.bb:do_patch) failed with exit code '1'

Thanks and Regards
Choong YinThong

From: Burton, Ross [mailto:ross.burton at intel.com]
Sent: Monday, April 3, 2017 5:17 PM
To: Kukkonen, Jussi <jussi.kukkonen at intel.com>
Cc: Choong, Yin Thong <yin.thong.choong at intel.com>; Patches and discussions about the oe-core layer <openembedded-core at lists.openembedded.org>
Subject: Re: [OE-core] [PATCH 4/8] logrotate: replace fedorahosted.org SRC_URI with yoctoproject.org source


On 3 April 2017 at 09:30, Jussi Kukkonen <jussi.kukkonen at intel.com<mailto:jussi.kukkonen at intel.com>> wrote:
This is true, there's not that much in the repo itself to create trust. The major show of trust is here though: http://pkgs.fedoraproject.org/cgit/rpms/logrotate.git/commit/?id=9cb55142e51b82085d6c3136448c1f441454e351
Fedora/Red Hat themselves changed to use this repo when the fedorahosted repos were EOL'd (see also Red Hat folks working on the github issues in January).

So logrotate was originally hosted on Fedora infrastructure that is then shut down, a github repository appears and Fedora fetch from that github repository.  Also the commit in the github repository to change the README from fedorahosted to github (https://github.com/logrotate/logrotate/commit/09c4fa8bc6cf2c01bad24d33c3ea69371030c014) was committed by a Red Hat employee (https://github.com/kdudka).

Whilst there are many official-looking forks on github that are just Some Guy, this is clearly the new canonical home.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170403/d3f01678/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1styocto_2ndgithub_logrotate.diff
Type: application/octet-stream
Size: 3102 bytes
Desc: 1styocto_2ndgithub_logrotate.diff
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170403/d3f01678/attachment-0002.obj>