[OE-core] [PATCH morty v2] wic: partition: Run fsck on EXT file systems

Khem Raj raj.khem at gmail.com
Mon Apr 3 15:41:32 UTC 2017


On Mon, Apr 3, 2017 at 12:47 AM, Daniel Schultz <d.schultz at phytec.de> wrote:
> Hi,
>
> Am 31.03.2017 um 19:14 schrieb Khem Raj:
>>
>>
>>
>> On 3/31/17 5:51 AM, Daniel Schultz wrote:
>>>
>>> Mkfs may create EXT file systems which can only be optimized by fsck
>>> and not by itself, e.g. directory optimization (in Pass 3A).
>>>
>>> To prevent those optimizations during runtime, it will be performed after
>>> the creation of an EXT file system.
>>>
>>> Signed-off-by: Daniel Schultz <d.schultz at phytec.de>
>>> ---
>>>  scripts/lib/wic/partition.py | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/scripts/lib/wic/partition.py b/scripts/lib/wic/partition.py
>>> index 3b3bd2d..152eb7b 100644
>>> --- a/scripts/lib/wic/partition.py
>>> +++ b/scripts/lib/wic/partition.py
>>> @@ -239,6 +239,9 @@ class Partition():
>>>              (self.fstype, extra_imagecmd, rootfs, label_str, rootfs_dir)
>>>          exec_native_cmd(mkfs_cmd, native_sysroot, pseudo=pseudo)
>>>
>>> +        mkfs_cmd = "fsck.%s -pvfD %s" % (self.fstype, rootfs)
>>> +        exec_native_cmd(mkfs_cmd, native_sysroot, pseudo=pseudo)
>>> +
>>
>>
>> is this required on master too ? if yes I would suggest to propose it
>> for master and then do a backport.
>>
>
> Yes, it's already on master. If I would backport it, I also have to backport
> a patch for e2fsprogs.
> Since the new release is very close I would prefer this patch.
>

it might be fine for your internal release. For upstream release branches we
should go by backports.



More information about the Openembedded-core mailing list