[OE-core] [PATCH 0/1] Restore proper attributions to libsolv patch

Maxin B. John maxin.john at intel.com
Tue Apr 11 08:13:45 UTC 2017


Hi Mark,

On Mon, Apr 10, 2017 at 03:58:27PM -0500, Mark Hatle wrote:
> 
> Per the email: http://lists.openembedded.org/pipermail/openembedded-core/2017-April/135460.html
> 
> Neal's attribution to the original code was lost.  In addition the original
> two patches were squashed together.  This was not indicated in any change
> information.  Again, making it unclear the proper history of the patches.

My apologies to Neal. I thought preserving the signed-off-by and link to github was
a way to credit the original author, which is technically not correct. 

> The associated change has no technical content change to the patches, it
> is purely cosmetic.  The attempt is to restore the original unmodified
> patches, including all attributions.  Maxim's patch to the if clause
> in one hunk was then restored on top.
> 
> Let me know if there are any questions or concerns with this set.
> 
> (Note, Neal has not provided a signed-off-by line, which is his right as
> an external author.  Since I modified the code, I did not add Maxim's either
> as I do not have the right to add a signed-off-by line by someone else
> without their express permission.)
> 
> Mark Hatle (1):
>   libsolve: 0001-Add-fallback-fopencookie-implementation.patch fix
>     attribution
> 
>  ...1-Add-fallback-fopencookie-implementation.patch | 186 +++++++++++++++++----
>  1 file changed, 150 insertions(+), 36 deletions(-)
>

Best Regards,
Maxin



More information about the Openembedded-core mailing list