[OE-core] [PATCH 3/4] autogen: update libopts.m4's patch

[Robert Yang]

On 04/14/2017 05:46 PM, Richard Purdie wrote:
> On Thu, 2017-04-13 at 02:57 -0700, Robert Yang wrote:
>> Use 'test -n "$POSIX_SHELL"' rather than 'test -x "$POSIX_SHELL"' so
>> that 'POSIX_SHELL = "/usr/bin/env sh"' can work.
>
>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>> ---
>>  .../0001-config-libopts.m4-regenerate-it-from-config-
>> libopts..patch     | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/autogen/autogen/0001-config-
>> libopts.m4-regenerate-it-from-config-libopts..patch b/meta/recipes-
>> devtools/autogen/autogen/0001-config-libopts.m4-regenerate-it-from-
>> config-libopts..patch
>> index a14018e..e247594 100644
>> --- a/meta/recipes-devtools/autogen/autogen/0001-config-libopts.m4-
>> regenerate-it-from-config-libopts..patch
>> +++ b/meta/recipes-devtools/autogen/autogen/0001-config-libopts.m4-
>> regenerate-it-from-config-libopts..patch
>> @@ -30,7 +30,7 @@ index c7ba4f3..51e6a39 100644
>>     AC_PROG_SED
>>     [while :
>>     do
>> -+      test -x "$POSIX_SHELL" && break
>> ++      test -n "$POSIX_SHELL" && break
>>         POSIX_SHELL=`which bash`
>>         test -x "$POSIX_SHELL" && break
>>         POSIX_SHELL=`which dash`
>
>
> The patch title makes this sound it it was some kind of regenerated
> file. You're then patching this for a rather subtle bug. I worry that
> this change is going to get lost in the future when someone regenerates
> this.

Cool, you are right.

>
> I'm wondering if we can find a better, more future proof solution?

I will think more about it.

// Robert

>
> Cheers,
>
> Richard
>