[OE-core] Building logrotate for older releases is broken (was: RE: [PATCH 1/1] logrotate: set downloadfilename)

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org
> [mailto:openembedded-core-bounces at lists.openembedded.org] On Behalf Of
> Robert Yang
> Sent: den 17 april 2017 11:49
> To: openembedded-core at lists.openembedded.org
> Subject: [OE-core] [PATCH 1/1] logrotate: set downloadfilename
> 
> Otherwise, the filename is r3-9-1.tar.gz which isn't straightforward.
> 
> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
> ---
>  meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> index c938d9f..3773170 100644
> --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> @@ -19,7 +19,7 @@ S = "${WORKDIR}/${BPN}-r3-9-1"
> 
>  UPSTREAM_CHECK_URI = "https://github.com/${BPN}/${BPN}/releases"
> 
> -SRC_URI = "https://github.com/${BPN}/${BPN}/archive/r3-9-1.tar.gz \
> +SRC_URI = "https://github.com/${BPN}/${BPN}/archive/r3-9-1.tar.gz;downloadfilename=${BP}.tar.gz\
>             file://act-as-mv-when-rotate.patch \
>             file://update-the-manual.patch \
>             file://disable-check-different-filesystems.patch \
> --
> 2.10.2

The integration of this patch into OE-Core has broken building old 
releases that rely on fetching the logrotate-3.9.1.tar.gz tar ball 
with MD5 checksum 4492b145b6d542e4a2f41e77fa199ab0 from the mirror 
at http://downloads.yoctoproject.org/mirror/sources/. Can you please 
change the recipe to not call the downloaded tar ball the same name 
as it had in Jethro, Krogoth and Morty (given that the checksums do 
not match), and then restore the original tar ball in the mirror?

Without this correction, it is impossible to recreate old builds 
based on either of the Jethro, Krogoth and Morty releases without 
doing manual fixes.

//Peter