[OE-core] [PATCHv2] oe-selftest: add a test for upstream version check regressions

[Alexander Kanavin]

The test runs an upstream version check, and then compares the
list of recipes that failed the check (i.e. those where latest
upstream version could not be established) against the list of
known-broken upstreams. Mismatches either way (upstream check failed,
recipe not in the exception list, or upstream check worked,
recipe in exception list) fail the test.

[YOCTO #11031]

Signed-off-by: Alexander Kanavin <alexander.kanavin at linux.intel.com>
---
 meta-selftest/files/distrodata/checkpkg_exceptions | 28 +++++++++++++++
 meta/lib/oeqa/selftest/distrodata.py               | 42 ++++++++++++++++++++++
 2 files changed, 70 insertions(+)
 create mode 100644 meta-selftest/files/distrodata/checkpkg_exceptions
 create mode 100644 meta/lib/oeqa/selftest/distrodata.py

diff --git a/meta-selftest/files/distrodata/checkpkg_exceptions b/meta-selftest/files/distrodata/checkpkg_exceptions
new file mode 100644
index 00000000000..9431d15d45c
--- /dev/null
+++ b/meta-selftest/files/distrodata/checkpkg_exceptions
@@ -0,0 +1,28 @@
+build-compare
+calibrateproto
+dbus-wait
+distcc
+fstests
+gnu-config
+gst-player
+kmscube
+libfakekey
+libxcalibrate
+linux-firmware
+lsb
+mailx
+mmc-utils
+ovmf
+piglit
+psplash
+puzzles
+rpm
+squashfs-tools
+tcf-agent
+unzip
+update-rc.d
+x264
+xcursor-transparent-theme
+xinetd
+xvideo-tests
+zip
diff --git a/meta/lib/oeqa/selftest/distrodata.py b/meta/lib/oeqa/selftest/distrodata.py
new file mode 100644
index 00000000000..47fdebfee56
--- /dev/null
+++ b/meta/lib/oeqa/selftest/distrodata.py
@@ -0,0 +1,42 @@
+from oeqa.selftest.base import oeSelfTest
+from oeqa.utils.commands import runCmd, bitbake, get_bb_var, get_bb_vars
+from oeqa.utils.decorators import testcase
+from oeqa.utils.ftools import write_file
+
+class Distrodata(oeSelfTest):
+
+    @classmethod
+    def setUpClass(cls):
+        pass
+
+    def test_checkpkg(self):
+        """
+        Summary:     Test that upstream version checks do not regress
+        Expected:    Upstream version checks should succeed except for the recipes listed in the exception list.
+        Product:     oe-core
+        Author:      Alexander Kanavin <alexander.kanavin at intel.com>
+        """
+        feature = 'INHERIT += "distrodata"\n'
+        feature += 'LICENSE_FLAGS_WHITELIST += " commercial"\n'
+
+        self.write_config(feature)
+        bitbake('-c checkpkg world')
+        checkpkg_result = open(os.path.join(get_bb_var("LOG_DIR"), "checkpkg.csv")).readlines()[1:]
+        exceptions = [exc.strip() for exc in open(os.path.join(self.testlayer_path, 'files', 'distrodata', "checkpkg_exceptions")).readlines()]
+        failed_upstream_checks = [pkg_data[0] for pkg_data in [pkg_line.split('\t') for pkg_line in checkpkg_result] if pkg_data[11] == '']
+        regressed_failures = set(failed_upstream_checks) - set(exceptions)
+        regressed_successes = set(exceptions) - set(failed_upstream_checks)
+        msg = ""
+        if len(regressed_failures) > 0:
+            msg = msg + """
+The following packages failed upstream version checks. Please fix them using UPSTREAM_CHECK_URI/UPSTREAM_CHECK_REGEX
+(when using tarballs) or UPSTREAM_CHECK_GITTAGREGEX (when using git). If an upstream version check cannot be performed
+(for example, if upstream does not use git tags), you can add the package to list of exceptions in
+meta-selftest/files/distrodata/checkpkg_exceptions.
+""" + "\n".join(regressed_failures)
+        if len(regressed_successes) > 0:
+            msg = msg + """
+The following packages have been checked successfully for upstream versions (or they no longer exist in oe-core),
+but are in the exceptions list in meta-selftest/files/distrodata/checkpkg_exceptions. Please remove them from that list.
+""" + "\n".join(regressed_successes)
+        self.assertTrue(len(regressed_failures) == 0 and len(regressed_successes) == 0, msg)
-- 
2.11.0