[OE-core] [PATCH 1/2] grub: Fix build with gcc7

[Burton, Ross]

On 21 April 2017 at 22:09, Khem Raj <raj.khem at gmail.com> wrote:

> backport patches from upsteam and adapt them to 2.0 codebase
>

This fails for me (and the autobuilders) in grub-core/video/i386/pc/vbe.c
which was fixed upstream in 2015 and the file hasn't been touched since.

This makes me wonder why are we building code that was released before
then, and is VBE still a thing?  Last time I remember seeing those letters
was around 2000 on my new Pentium...

Fix those and now it fails for me in:

 ../../grub-2.00/grub-core/loader/i386/pc/linux.c: In function
'grub_cmd_linux':
| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:254:9: error: this
statement may fall through [-Werror=implicit-fallthrough=]
|    shift += 10;
|    ~~~~~~^~~~~
| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:255:8: note: here
|         case 'm':
|         ^~~~
| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:256:9: error: this
statement may fall through [-Werror=implicit-fallthrough=]
|    shift += 10;
|    ~~~~~~^~~~~
| ../../grub-2.00/grub-core/loader/i386/pc/linux.c:257:8: note: here
|         case 'k':
|         ^~~~

Clearly there's some build difference between our configurations. Are you
building grub-git instead of grub_2.00?  Should we delete grub_2.00 if its
that old?  I'd say that it looks good for a new upstream 2.02 release as
there is a 2.02-rc2 tagged just six weeks ago, but 2.02-beta1 was tagged
three years ago...

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170424/ef582136/attachment-0002.html>