[OE-core] [PATCHv4 2/4] recipetool: create: being able to set branch when revision is provided

[Burton, Ross]

On 27 July 2017 at 09:40, Chang Rebecca Swee Fun <
rebecca.swee.fun.chang at intel.com> wrote:

> When recipetool create is run on a git URL and a revision specified
> that is not on master, and "branch=" isn't already in the URL, then
> we should get the correct branch and append the branch to the URL.
>
> If the revision was found on multiple branches, we will display error
> to inform user to provide a correct branch and exit.
>

I think this is causing the selftests to fail:

2017-08-02 04:16:40,204 - oe-selftest - INFO - FAIL [12.984s]:
test_recipetool_create_git (recipetool.RecipetoolTests)
2017-08-02 04:16:40,204 - oe-selftest - INFO -
----------------------------------------------------------------------
2017-08-02 04:16:40,205 - oe-selftest - INFO - Traceback (most recent call
last):
  File
"/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/core/decorator/__init__.py",
line 32, in wrapped_f
    return func(*args, **kwargs)
  File
"/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/cases/recipetool.py",
line 403, in test_recipetool_create_git
    self._test_recipe_contents(recipefile, checkvars, inherits)
  File
"/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/cases/devtool.py",
line 52, in _test_recipe_contents
    self.assertEqual(value, needvalue, 'values for %s do not match' % var)
AssertionError: 'git://git.yoctoproject.org/libmatchbox;branch=master' !=
'git://git.yoctoproject.org/libmatchbox'
- git://git.yoctoproject.org/libmatchbox;branch=master
?                                       --------------
+ git://git.yoctoproject.org/libmatchbox

 : values for SRC_URI do not match

Looks like recipetool is adding branch=master even though that is the
default value so I'd suggest should be filtered out.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170802/76d668c2/attachment-0002.html>