[OE-core] [PATCH 2/2] sstatetests: limit the number of signature comparisons when differ

Leonardo Sandoval leonardo.sandoval.gonzalez at linux.intel.com
Mon Aug 7 17:19:18 UTC 2017


On Mon, 2017-08-07 at 18:05 +0100, Burton, Ross wrote:
> On 7 August 2017 at 18:06, Leonardo Sandoval
> <leonardo.sandoval.gonzalez at linux.intel.com> wrote:
>         yes, but we this way, we are not listing those > 20 and I
>         believe this
>         is important. This fix just diffsigs the first 20, and the
>         rest are just
>         listed for convenience.
> 
> 
> Good point.  You could neatly print the filenames in one iteration,
> and then the first 20 diffs in another loop.

not super convinced but yes, that can be a another way to avoid the if
inside the for body. I will send a v2.

Leo
> 
> 
>         also, sets are not 'subscriptable' thus slicing is not
>         possible on sets.
> 
> 
> Which is why I called list() before slicing.
> 
> 
> Ross 





More information about the Openembedded-core mailing list