[OE-core] [PATCH v2 7/7] dnf: expand dnf selftest to test signed package feeds

Alexander Kanavin alexander.kanavin at linux.intel.com
Mon Aug 14 11:16:06 UTC 2017


On 08/11/2017 06:35 PM, Markus Lehtonen wrote:
>   
>           import re
> -        output_makecache = self.dnf('makecache')
> +        output_makecache = self.dnf('-y makecache')

Why add '-y'? Can you add a comment (just prior to this line) explaining 
what question dnf is asking?

> +        self.assertTrue(re.match(r".*Failed to synchronize cache", output_makecache, re.DOTALL) is None, msg = "dnf makecache failed to synchronize repo: %s" %(output_makecache))
>           self.assertTrue(re.match(r".*Metadata cache created", output_makecache, re.DOTALL) is not None, msg = "dnf makecache failed: %s" %(output_makecache))
>   
>           output_repoinfo = self.dnf('repoinfo')

Do 'makecache' or 'repoinfo' print any indication that repo signing is 
in use and working correctly? Can you check for presence of that in the 
commands' output?

Alex



More information about the Openembedded-core mailing list