[OE-core] [PATCH] gpg_sign: perform rpm signing serially
Andre McCurdy
armccurdy at gmail.com
Wed Aug 16 15:36:30 UTC 2017
On Wed, Aug 16, 2017 at 5:28 AM, Markus Lehtonen
<markus.lehtonen at linux.intel.com> wrote:
> I agree. I don't see reason for dropping parallelism completely. There is a real gain when running on beefier machines. Making it configurable would probably be best. Or just drop it to a saner value, like 20 or 10.
Deriving a value from PARALLEL_MAKE or BB_NUMBER_THREADS might be
better than defining a new variable or hardcoding.
> - Markus
>
> On 16/08/2017, 2.53, "Mark Hatle" <openembedded-core-bounces at lists.openembedded.org on behalf of mark.hatle at windriver.com> wrote:
>
> It would probably be better if this was configurable with a 'safe' default.
>
> Moving from parallel to single will greatly affect the overall performance on
> larger build machines (lots of memory and cores) that can handle the load vs a
> typical development machine.
>
> --Mark
>
> On 8/15/17 4:40 PM, leonardo.sandoval.gonzalez at linux.intel.com wrote:
> > From: Leonardo Sandoval <leonardo.sandoval.gonzalez at linux.intel.com>
> >
> > gpg signing in file batches (which was default to 100) is a memory expensive
> > computation, causing trouble in some host machines (even on production AB
> > as seen on the bugzilla ID). Also, in terms of performance, there is no real
> > gain when rpm signing is done in batches. Considering the latter issues, perform the
> > rpm signing serially.
> >
> > Log showing errors observed recently at AB workers:
> >
> > | gpg: signing failed: Cannot allocate memory
> > | gpg: signing failed: Cannot allocate memory
> > | error: gpg exec failed (2)
> > | /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/build/tmp/work/core2-64-poky-linux/base-passwd/3.5.29-r0/deploy-rpms/core2_64/base-passwd-dev-3.5.29-r0.core2_64.rpm:
> >
> > [YOCTO #11914]
> >
> > Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez at linux.intel.com>
> > ---
> > meta/lib/oe/gpg_sign.py | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/meta/lib/oe/gpg_sign.py b/meta/lib/oe/gpg_sign.py
> > index f4d8b10e4b..5c7985a856 100644
> > --- a/meta/lib/oe/gpg_sign.py
> > +++ b/meta/lib/oe/gpg_sign.py
> > @@ -45,9 +45,9 @@ class LocalSigner(object):
> > if fsk_password:
> > cmd += "--define '_file_signing_key_password %s' " % fsk_password
> >
> > - # Sign in chunks of 100 packages
> > - for i in range(0, len(files), 100):
> > - status, output = oe.utils.getstatusoutput(cmd + ' '.join(files[i:i+100]))
> > + # Sign packages
> > + for f in files:
> > + status, output = oe.utils.getstatusoutput(cmd + ' ' + f)
> > if status:
> > raise bb.build.FuncFailed("Failed to sign RPM packages: %s" % output)
> >
> >
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
More information about the Openembedded-core
mailing list