[OE-core] [PATCH v2] image.bbclass: delete DATE variable too

Stefan Agner stefan at agner.ch
Thu Aug 17 17:34:07 UTC 2017


On 2017-08-29 02:54, Stefan Agner wrote:
> From: Stefan Agner <stefan.agner at toradex.com>
> 
> When creating a custom image which uses the DATE variable the basehash
> seems to change every day and lead to errors such as:
> ERROR: console-tdx-image-2.7.6-r0 do_image_customimg: Error executing
> a python function in exec_python_func() autogenerated:
> 
> The stack trace of python calls that resulted in this exception/failure was:
> File: 'exec_python_func() autogenerated', lineno: 2, function: <module>
>      0001:
>  *** 0002:set_image_size(d)
> ...
> 
> Add DATE to the variables which should not get expanded early and to the
> vardepsexclude list for the image task.

Armin, this has been applied to master in between.

Is there a chance to get that also into pyro and morty?

--
Stefan


> 
> Signed-off-by: Stefan Agner <stefan.agner at toradex.com>
> ---
> I am not that deep in OE usually and I am not sure if I miss something
> completely here... It seems to solve the issue for us though. Does that
> change sounds reasonable? Could it be done in the custom image class file?
> 
>  meta/classes/image.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 2c1dc81..7949b46 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -437,6 +437,7 @@ python () {
>          # date/time values. It will get expanded at execution time.
>          # Similarly TMPDIR since otherwise we see QA stamp comparision problems
>          localdata.delVar('DATETIME')
> +        localdata.delVar('DATE')
>          localdata.delVar('TMPDIR')
>  
>          image_cmd = localdata.getVar("IMAGE_CMD")
> @@ -501,7 +502,7 @@ python () {
>          d.prependVarFlag(task, 'postfuncs', ' create_symlinks')
>          d.appendVarFlag(task, 'subimages', ' ' + ' '.join(subimages))
>          d.appendVarFlag(task, 'vardeps', ' ' + ' '.join(vardeps))
> -        d.appendVarFlag(task, 'vardepsexclude', 'DATETIME')
> +        d.appendVarFlag(task, 'vardepsexclude', 'DATETIME DATE')
>  
>          bb.debug(2, "Adding task %s before %s, after %s" % (task,
> 'do_image_complete', after))
>          bb.build.addtask(task, 'do_image_complete', after, d)



More information about the Openembedded-core mailing list