[OE-core] [PATCH] insane.bbclass: write QA issues to log file only when thei are in ERROR_QA or WARN_QA

[Martin Jansa]

Just notice typo in subject s/thei/they/g, will resend soon, in the
meantime is there some feedback on this?

Alternatively we can write them with NOTE: WARN: ERROR: prefix like with
the logger, so that the qa.log can be filtered by severity of the issue.

TL;DR; version:
In my jenkins builds I'm printing content of qa.log at the end of usually
very long build log, so that they are easier to spot in one place and
because I get a lot of "version-going-backwards" warnings which I'm not
interested in anymore at all, I've removed them from ERROR_QA - but then I
was wondering why I still see very long list of "version-going-backwards"
warnings, but those were from qa.log. It would work for me fine to just
"grep -v ^NOTE: qa.log" at the end of jenkins build if the alternative
solution is more acceptable.

On Mon, Aug 21, 2017 at 8:56 AM, Martin Jansa <martin.jansa at gmail.com>
wrote:

> * QA check which aren't included in WARN_QA and ERROR_QA are shown
>   during the build only as NOTE message (not shown at all with default
>   knotty setting), so it might be surprising to see them later in qa.log
>   file
>
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
>  meta/classes/insane.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index b7177c9b32..44e4a01c92 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -184,12 +184,13 @@ def package_qa_write_error(type, error, d):
>              f.write("%s: %s [%s]\n" % (p, error, type))
>
>  def package_qa_handle_error(error_class, error_msg, d):
> -    package_qa_write_error(error_class, error_msg, d)
>      if error_class in (d.getVar("ERROR_QA") or "").split():
> +        package_qa_write_error(error_class, error_msg, d)
>          bb.error("QA Issue: %s [%s]" % (error_msg, error_class))
>          d.setVar("QA_SANE", False)
>          return False
>      elif error_class in (d.getVar("WARN_QA") or "").split():
> +        package_qa_write_error(error_class, error_msg, d)
>          bb.warn("QA Issue: %s [%s]" % (error_msg, error_class))
>      else:
>          bb.note("QA Issue: %s [%s]" % (error_msg, error_class))
> --
> 2.14.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170821/392f41bd/attachment-0002.html>