[OE-core] [PATCH] scripts/buildhistory-diff: use of argparse instead of optparse

Paul Eggleton paul.eggleton at linux.intel.com
Sun Aug 27 21:42:37 UTC 2017


Hi Daniela,

On Saturday, 26 August 2017 6:49:56 AM NZST daniela.plascencia at linux.intel.com wrote:
> -    except gitdb.exc.BadObject as e:
> -        if len(args) == 1:
> +        changes = process_changes(args.buildhistory_dir, fromrev, torev,
> +                                  args.report_all, args.report_ver, args.sigs,
> +                                  args.sigsdiff, args.exclude_path)
> +    except gitdb.exc.BadName as e:

This change wasn't mentioned in the commit message and isn't directly
related. Did you see a different exception in your testing? Are you sure 
BadObject won't also be raised?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the Openembedded-core mailing list