[OE-core] [PATCH] gettext.bbclass: do not add virtual/gettext to DEPENDS
Richard Purdie
richard.purdie at linuxfoundation.org
Tue Aug 29 10:32:57 UTC 2017
On Tue, 2017-08-29 at 12:55 +0300, Alexander Kanavin wrote:
> gettext has a notoriously slow configuration step, and so in my
> testing this greatly speeds up building core-image-minimal: from
> 21m36s to 19m2s (empty sstate and tmp, but pre-populated downloads).
>
> I have also built world, and core-image-sato to make sure it doesn't
> break or modify the build, and there is no difference whatsoever in
> packages and images content. Target gettext not seems to be used for
> anything.
>
> Also fix up insane.bbclass to remove the corresponding QA check.
I like this idea, one small question below...
> diff --git a/meta/classes/insane.bbclass
> b/meta/classes/insane.bbclass
> index b7177c9b329..a2ec466775f 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -1183,9 +1183,9 @@ Rerun configure task after fixing this.""")
> elif bb.data.inherits_class('cross-canadian', d):
> gt = "nativesdk-gettext"
> else:
> - gt = "virtual/" + ml + "gettext"
> + gt = None
Should this be gettext-native?
> deps = bb.utils.explode_deps(d.getVar('DEPENDS') or "")
> - if gt not in deps:
> + if gt is not None and gt not in deps:
> for config in configs:
> gnu = "grep \"^[[:space:]]*AM_GNU_GETTEXT\" %s
> >/dev/null" % config
> if subprocess.call(gnu, shell=True) == 0:
Cheers,
Richard
More information about the Openembedded-core
mailing list