[OE-core] [PATCH] musl: prevent errors if do_install is run more than once

Khem Raj raj.khem at gmail.com
Fri Dec 1 21:53:24 UTC 2017


On Fri, Dec 1, 2017 at 1:22 PM Matthew McClintock <msm-oss at mcclintock.net>
wrote:

> On Fri, Dec 1, 2017 at 2:13 PM, Khem Raj <raj.khem at gmail.com> wrote:
> > On Fri, Dec 1, 2017 at 11:30 AM, Andre McCurdy <armccurdy at gmail.com>
> wrote:
> >> On Fri, Dec 1, 2017 at 3:07 AM, Burton, Ross <ross.burton at intel.com>
> wrote:
> >>> Extend lnr to have a --force option?
> >>
> >> Is there ever a case where we want lnr to fail if the target already
> exists?
> >>
> >> There are plenty of existing examples in oe-core where rm is run
> >> before lnr (and in the cases where it's not, it's perhaps just a bug
> >> or an oversight).
> >>
> >> So I think either leave the v1 patch as-is and run rm before lnr in
> >> musl do_install as we already do elsewhere, or update lnr so that it
> >> unconditionally removes any pre-existing target?
> >
> > I like Ross'es suggestion to modify lnr implementation as an
> > independent patch and
> > rebase your patch on top. Maybe a cleanup later to remove all rm cmds
> > that are used
> > before lnr
>
> Do we keep the lnr filename? Change to ln-python and add -r and -f?
>
> The above question wasn't answered. Should we just always force it and
> emit a WARNING if it's being replaced?


It’s should force replace it yes a note about replacing an existing file if
any is fine

>
>
> -M
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20171201/6ee88e8f/attachment-0002.html>


More information about the Openembedded-core mailing list