[OE-core] [PATCH 5/5] lib/oe/package.py: is_elf: Make it less prone to false positives

Olof Johansson olof.johansson at axis.com
Mon Dec 4 10:00:28 UTC 2017


On 17-12-01 22:13 +0100, Olof Johansson wrote:
> On 17-12-01 11:43 -0600, Mark Hatle wrote:
> > The original implementation did not include the ',' options because different
> > versions of file (as well as different architectures) would return different
> > strings.
> > 
> > They all contains the same information, but order and inclusion of ',' changed
> > regularly.
> > 
> > So I would caution that for this to check out a wide variety of host systems and
> > architectures would need to be verified.  (It's very possible that all modern
> > systems now conform to a single standard...)
> 
> I was a little bit worried about this, thanks, this is useful
> feedback. Perhaps dropping the "," while still retaining the
> whitespace delimitation could be enough, and still work with a
> variety of file implementations?

Reading more about this, I was wrong in calling it GNU file, I
don't know where I got that from. It actually seems to be only
one prevalent implementation, one written by Ian Darwin [0]:

> Who's using it?
>
>    Most known BSD distributions (FreeBSD, NetBSD, Darwin/Mac OS X, etc)
>    Every known Linux distribution

Could you elaborate on the portability issues you've seen?


0: http://www.darwinsys.com/file/

-- 
olofjn



More information about the Openembedded-core mailing list