[OE-core] [PATCH 2/2] wic: plugins: rawcopy: Add support to download the raw image from a http server

[Martin Hundebøll]

On 2017-12-11 12:45, Otavio Salvador wrote:
> On Mon, Dec 11, 2017 at 3:30 AM, Kevin Hao <kexin.hao at windriver.com> wrote:
>> On Sun, Dec 10, 2017 at 10:53:43PM -0200, Otavio Salvador wrote:
>>> On Sat, Dec 9, 2017 at 12:45 AM, Kevin Hao <kexin.hao at windriver.com> wrote:
>>>> Some firmwares are critical for the basic functions of the board, and may
>>>> be used by the bootloader. Due to the license issue, we can't integrate
>>>> it. But we do need it when creating a booting image by using WIC.
>>>> So add the support for the WIC to download a raw file from http
>>>> server and write it to a specific part. In order to restrict the
>>>> downloading behaviour, we introduce a "WKS_ALLOW_DOWNLOAD" variable and
>>>> only do the downloading when this variable is set.
>>>>
>>>> Signed-off-by: Kevin Hao <kexin.hao at windriver.com>
>>>
>>> This does not make much sense.
>>>
>>> It does not allow to be downloaded? so build system can download it
>>> and use it as a normal artifact.
>>
>> In some cases, it doesn't make sense to do so. Because:
>> a) These firmwares are just raw binary files, they don't need any build or
>>     process. They are only useful when we try to create a bootable image.
> 
> In any case, keep them on the download cache is a good thing as it
> avoids build issues due network instability and avoids as well
> undesired file content changes.
> 
>> b) There firmwares may be licensed under a proprietary license. We may not
>>     integrate them to a fully open source build system. But we do want to provide
>>     an easy way for the customer to build a bootable image.
> 
> Sure and I agree, but this is what layers are for.
> 

I agree with Otavio here. Images built with OE / Bitbake should list all 
their sources in SRC_URIs.

Our (internal) releases includes images with all the sources needed to 
build the final target images, and we have had issues before with make 
systems pulling in sources in do_configure.

I don't personally think do_image_wic is any different than do_configure 
in this regard.

// Martin