[OE-core] [PATCH 5/5] lib/oe/package.py: is_elf: Make it less prone to false positives

[Burton, Ross]

On 18 December 2017 at 11:28, Burton, Ross <ross.burton at intel.com> wrote:

> On 18 December 2017 at 11:06, Olof Johansson <olof.johansson at axis.com>
> wrote:
>
>> I'm so sorry, I missed your email; I am, but maybe not as quickly
>> as you are able to(?). My is_stripped looks kind of like yours,
>> but without the ShType.progbits. Thanks for the suggestion! I
>> were able to hackishly integrate the Elf class it with
>> staging.bbclass and package.bbclass.
>>
>> I did have a couple of questions; if I were to add an is_stripped
>> method, would that fit best in the Elf class itself or in some
>> wrapper?  Would renaming the elf class to "ElfParser" class make
>> more sense, and have an ELF class that wraps it? I can publish a
>> draft somewhere later today.
>>
>
> The Elf class is generated with kaitai struct so I'm trying to reduce the
> number of changes to it, but we can definitely move it into a subpackage
> like oe.parsers.elf and then have oe.elf for just the utility method.
>

Just pushed ross/elf with this change.  The next obvious step is to turn
lib/oe/qa.py into a new lib/oe/elf.py which has a better API and includes
the stripped function.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20171218/c10633fa/attachment-0002.html>