[OE-core] [PATCH 05/18] wic: get rid of __rootfs_dir_to_dict method

Ed Bartosh ed.bartosh at linux.intel.com
Wed Feb 1 13:48:12 UTC 2017


Replaced class method __rootfs_dir_to_dict with a list
comprehension.

[YOCTO #10619]

Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
---
 scripts/lib/wic/plugins/imager/direct_plugin.py | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/scripts/lib/wic/plugins/imager/direct_plugin.py b/scripts/lib/wic/plugins/imager/direct_plugin.py
index 91a9792..c6df5fb 100644
--- a/scripts/lib/wic/plugins/imager/direct_plugin.py
+++ b/scripts/lib/wic/plugins/imager/direct_plugin.py
@@ -53,21 +53,8 @@ class DirectPlugin(ImagerPlugin):
 
     name = 'direct'
 
-    @classmethod
-    def __rootfs_dir_to_dict(cls, rootfs_dirs):
-        """
-        Gets a string that contain 'connection=dir' splitted by
-        space and return a dict
-        """
-        krootfs_dir = {}
-        for rootfs_dir in rootfs_dirs.split(' '):
-            key, val = rootfs_dir.split('=')
-            krootfs_dir[key] = val
-
-        return krootfs_dir
-
-    @classmethod
-    def do_create(cls, opts, *args):
+    @staticmethod
+    def do_create(opts, *args):
         """
         Create direct image, called from creator as 'direct' cmd
         """
@@ -92,7 +79,9 @@ class DirectPlugin(ImagerPlugin):
 
         image_name = "%s-%s" % (splitext(basename(ksconf))[0],
                           strftime("%Y%m%d%H%M"))
-        krootfs_dir = cls.__rootfs_dir_to_dict(rootfs_dir)
+
+        # parse possible 'rootfs=name' items
+        krootfs_dir = dict(rdir.split('=') for rdir in rootfs_dir.split(' '))
 
         creator = DirectImageCreator(image_name, ksobj, oe_builddir,
                                      image_output_dir, krootfs_dir,
-- 
2.1.4




More information about the Openembedded-core mailing list