[OE-core] [PATCH 1/4] selftest/buildoptions: use a thinner image to test 'read-only-rootfs' feature

[Leonardo Sandoval]

On 01/31/2017 05:16 PM, Richard Purdie wrote:
> On Tue, 2017-01-31 at 16:50 -0600,
> leonardo.sandoval.gonzalez at linux.intel.com wrote:
>> From: Leonardo Sandoval <leonardo.sandoval.gonzalez at linux.intel.com>
>>
>> The minimal is much faster to build that sato, so use the former to
>> test
>> read-only feature.
>>
>> Signed-off-by: Leonardo Sandoval <leonardo.sandoval.gonzalez at linux.in
>> tel.com>
>> ---
>>   meta/lib/oeqa/selftest/buildoptions.py | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/meta/lib/oeqa/selftest/buildoptions.py
>> b/meta/lib/oeqa/selftest/buildoptions.py
>> index d40eb00..004b2dd 100644
>> --- a/meta/lib/oeqa/selftest/buildoptions.py
>> +++ b/meta/lib/oeqa/selftest/buildoptions.py
>> @@ -44,11 +44,8 @@ class ImageOptionsTests(oeSelfTest):
>>   
>>       @testcase(1435)
>>       def test_read_only_image(self):
>> -        distro_features = get_bb_var('DISTRO_FEATURES')
>> -        if not ('x11' in distro_features and 'opengl' in
>> distro_features):
>> -            self.skipTest('core-image-sato requires x11 and opengl
>> in distro features')
>>           self.write_config('IMAGE_FEATURES += "read-only-rootfs"')
>> -        bitbake("core-image-sato")
>> +        bitbake("core-image-minimal")
>>           # do_image will fail if there are any pending postinsts
> Whilst this is certainly going to be a touch faster, I believe we do
> want to test read only rootfs with a larger image like sato to make
> sure the postinsts really do work with a read only system?

I don't get it. What would make the test different using a larger image?
>
> Cheers,
>
> Richard
>