[OE-core] [PATCH] runqemu: avoid overridden user input for bootparams

[Dmitry Rozhkov]

On Tue, 2017-02-28 at 11:52 +0100, Patrick Ohly wrote:
> On Tue, 2017-02-21 at 17:18 +0200, Dmitry Rozhkov wrote:
> > 
> > Currently runqemu hardcodes the "ip=" kernel boot parameter
> > when configuring QEMU to use tap or slirp networking. This makes
> > the guest system to have a network interface pre-configured
> > by kernel and causes systemd to fail renaming the interface
> > to whatever pleases it:
> > 
> >   Feb 21 10:10:20 intel-corei7-64 systemd-udevd[201]: Error
> > changing
> >       net interface name 'eth0' to 'enp0s3': Device or resource
> > busy,
> > 
> > Always append user input for kernel boot params after the ones
> > added by the script. This way user input has priority over
> > runqemu's
> > default params.
> 
> Presumably the user's bootparams then would include "ip="?

Yes, exactly that. "ip=" in the user's bootparams is the input that
shouldn't be ignored.

> Either way, the change looks good to me. I did something similar for
> the
> qemu parameters in "runqemu: let command line parameters override
> defaults".
> 

BR,
Dmitry