[OE-core] [PATCH 3/6] ksize.py: Python 3 fixes
Khem Raj
raj.khem at gmail.com
Wed Jan 4 06:39:33 UTC 2017
On Tue, Jan 3, 2017 at 2:30 PM, Alejandro Hernandez
<alejandro.hernandez at linux.intel.com> wrote:
> From: Tom Zanussi <tom.zanussi at linux.intel.com>
>
> String errors and partial __cmp__ fix.
may be fold it into previous patch.
>
> Signed-off-by: Tom Zanussi <tom.zanussi at linux.intel.com>
> ---
> scripts/tiny/ksize.py | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/tiny/ksize.py b/scripts/tiny/ksize.py
> index b9d2b19..ea1ca7f 100755
> --- a/scripts/tiny/ksize.py
> +++ b/scripts/tiny/ksize.py
> @@ -41,7 +41,7 @@ def usage():
> class Sizes:
> def __init__(self, glob):
> self.title = glob
> - p = Popen("size -t " + glob, shell=True, stdout=PIPE, stderr=PIPE)
> + p = Popen("size -t " + str(glob), shell=True, stdout=PIPE, stderr=PIPE)
> output = p.communicate()[0].splitlines()
> if len(output) > 2:
> sizes = output[-1].split()[0:4]
> @@ -62,18 +62,18 @@ class Report:
> r = Report(filename, title)
> path = os.path.dirname(filename)
>
> - p = Popen("ls " + path + "/*.o | grep -v built-in.o",
> + p = Popen("ls " + str(path) + "/*.o | grep -v built-in.o",
> shell=True, stdout=PIPE, stderr=PIPE)
> glob = ' '.join(p.communicate()[0].splitlines())
> - oreport = Report(glob, path + "/*.o")
> - oreport.sizes.title = path + "/*.o"
> + oreport = Report(glob, str(path) + "/*.o")
> + oreport.sizes.title = str(path) + "/*.o"
> r.parts.append(oreport)
>
> if subglob:
> p = Popen("ls " + subglob, shell=True, stdout=PIPE, stderr=PIPE)
> for f in p.communicate()[0].splitlines():
> path = os.path.dirname(f)
> - r.parts.append(Report.create(f, path, path + "/*/built-in.o"))
> + r.parts.append(Report.create(f, path, str(path) + "/*/built-in.o"))
> r.parts.sort(reverse=True)
>
> for b in r.parts:
> @@ -116,6 +116,13 @@ class Report:
> self.deltas["data"], self.deltas["bss"]))
> print("\n")
>
> + def __lt__(this, that):
> + if that is None:
> + return 1
> + if not isinstance(that, Report):
> + raise TypeError
> + return this.sizes.total < that.sizes.total
> +
> def __cmp__(this, that):
> if that is None:
> return 1
> --
> 2.6.6
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
More information about the Openembedded-core
mailing list