[OE-core] [PATCH 1/1] rootfs-postcommands.bbclass: sort passwd entries

Richard Purdie richard.purdie at linuxfoundation.org
Sat Jan 7 22:52:08 UTC 2017


On Sat, 2017-01-07 at 20:00 +0100, Patrick Ohly wrote:
> On Sat, 2017-01-07 at 09:59 +0000, Phil Blundell wrote:
> > 
> > On Sat, 2017-01-07 at 09:06 +0100, Patrick Ohly wrote:
> > > 
> > > 
> > Yes, but there's already a solution for that problem:
> > > 
> > > useradd-staticids.bbclass
> > > 
> > > I was assuming that someone who wants identical files is already
> > > using
> > > that. Should it be mentioned in a comment next to the new
> > > feature?
> > That sounds like a good idea.  And in that case, maybe it would be
> > better to sort on uid rather than username?  That would preserve
> > the
> > "traditional" ordering in the file, i.e. root first.
> I had thought about that, but then did not pursue that further
> because
> it would have made sorting quite a bit more complex (needs to know
> about
> line content, id not present in each file).
> 
> I can give it a try, though, if that's considered worth some
> additional
> complexity.

I think those functions can be python functions and this might not be
too bad to write in python....

Cheers,

Richard



More information about the Openembedded-core mailing list