[OE-core] [PATCH v3] kernel-module-split: Append KERNEL_VERSION string to kernel module name

[Bruce Ashfield]

On Mon, Jan 9, 2017 at 4:54 AM, <ola.redell at gmail.com> wrote:

> From: Ola Redell <ola.redell at retotech.se>
>
> The KERNEL_VERSION string is added to kernel module package names in order
> to
> make the kernel modules for different kernel versions distinct packages
> instead
> of different versions of the same package. With this change, when a new
> kernel
> is installed together with its kernel modules (e.g. by upgrade of the
> packages
> kernel and kernel-modules) using some package manager such as apt-get or
> rpm,
> the kernel modules for the older kernel will not be removed. This enables a
> fall back to the older kernel if the new one fails.
>


The functionality you describe is a good thing, but I have a few questions
to make
sure I understand the change, and confirm that existing functionality isn't
broken ..
and that the internals of the package management do the right thing (I'm
not an
expert on those internals .. so bear with me).

With this change, do you know if RDEPENDS="kernel-module-foo" still works ?
or
does it now have to be RDEPENDS="kernel-module-foo-<version>" ?

On a similar thought, "smart install kernel-module-foo" would also work ?
or does it
now require a version ?

Bruce


>
> Signed-off-by: Ola Redell <ola.redell at retotech.se>
> ---
>  meta/classes/kernel-module-split.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-module-split.bbclass
> b/meta/classes/kernel-module-split.bbclass
> index efe1b42..13cff51 100644
> --- a/meta/classes/kernel-module-split.bbclass
> +++ b/meta/classes/kernel-module-split.bbclass
> @@ -122,7 +122,7 @@ python split_kernel_module_packages () {
>      module_regex = '^(.*)\.k?o$'
>
>      module_pattern_prefix = d.getVar('KERNEL_MODULE_PACKAGE_PREFIX')
> -    module_pattern = module_pattern_prefix + 'kernel-module-%s'
> +    module_pattern = module_pattern_prefix + 'kernel-module-%s-' +
> d.getVar("KERNEL_VERSION", True)
>
>      postinst = d.getVar('pkg_postinst_modules')
>      postrm = d.getVar('pkg_postrm_modules')
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170109/3f36e37a/attachment-0002.html>