[OE-core] [PATCH V3 2/4] selftest: imagefeatures: skip tests based on distro features and supported fstypes

[Burton, Ross]

On 9 January 2017 at 17:45, <leonardo.sandoval.gonzalez at linux.intel.com>
wrote:

> +++ b/meta/lib/oeqa/selftest/imagefeatures.py
> @@ -77,6 +77,9 @@ class ImageFeatures(oeSelfTest):
>          AutomatedBy: Daniel Istrate <daniel.alexandrux.istrate at intel.com>
>          """
>
> +        if 'opengl' not in get_bb_var('DISTRO_FEATURES'):
> +            self.skipTest('opengl not present on DISTRO_FEATURES so
> core-image-clutter cannot be built')
> +
>          # Build a core-image-clutter
>          bitbake('core-image-clutter')
>

This test is pretty pointless, lets just delete it.


> @@ -91,6 +94,10 @@ class ImageFeatures(oeSelfTest):
>          AutomatedBy: Daniel Istrate <daniel.alexandrux.istrate at intel.com>
>          """
>
> +        distro_features = get_bb_var('DISTRO_FEATURES')
> +        if not ('opengl' in distro_features and 'wayland' in
> distro_features):
> +            self.skipTest('neither opengl nor wayland present on
> DISTRO_FEATURES so core-image-weston cannot be built')
> +
>          features = 'DISTRO_FEATURES_append = " wayland"\n'
>          features += 'CORE_IMAGE_EXTRA_INSTALL += "wayland weston"'
>          self.write_config(features)
>

This test is 90% nonsense, let's fix it whilst we're here.  After checking
that opengl and wayland are in DISTRO_FEATURES it can just build
core-image-weston: DISTRO_FEATURES doesn't need appending as it already has
wayland in, and CORE_IMAGE_EXTRA_INSTALL doesn't need extending as
core-image-weston obviously already contains weston.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20170111/2ed86590/attachment-0002.html>